Matthias Clasen [Sat, 3 May 2014 00:48:35 +0000 (20:48 -0400)]
a11y tests: Use the new AtkValue interface
The old interface is deprecated, and we just implemented the
new one, so lets test it.
Matthias Clasen [Sat, 3 May 2014 00:47:56 +0000 (20:47 -0400)]
GtkDialog: Reduce a g_warning to a g_message
Otherwise, this breaks our testsuite.
Matthias Clasen [Sat, 3 May 2014 00:47:16 +0000 (20:47 -0400)]
GtkSpinButton: Implement new AtkValue interface
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
Matthias Clasen [Sat, 3 May 2014 00:47:00 +0000 (20:47 -0400)]
GtkScaleButton: Implement new AtkValue interface
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
Matthias Clasen [Sat, 3 May 2014 00:46:45 +0000 (20:46 -0400)]
GtkRange: Implement new AtkValue interface
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
Matthias Clasen [Sat, 3 May 2014 00:46:30 +0000 (20:46 -0400)]
GtkProgressBar: Implement new AtkValue interface
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
Matthias Clasen [Sat, 3 May 2014 00:46:17 +0000 (20:46 -0400)]
GtkPaned: Implement new AtkValue interface
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
Matthias Clasen [Sat, 3 May 2014 00:45:19 +0000 (20:45 -0400)]
GtkLevelBar: Implement new AtkValue interface
The AtkValue interface has been replaced in ATK 2.12.
Implement the new one in addition to the old one.
Matthias Clasen [Fri, 2 May 2014 23:25:27 +0000 (19:25 -0400)]
GtkWidget: Mark deprecated properties as such
The ::style, ::margin-left and ::margin-right properties are all
deprecated.
Matthias Clasen [Fri, 2 May 2014 22:50:52 +0000 (18:50 -0400)]
Drop unneeded deprecation suppression
Removing this did not produce any deprecation warnings.
Matthias Clasen [Fri, 2 May 2014 22:48:36 +0000 (18:48 -0400)]
queryimmodules: Localize suppressed deprecation
Drop the blanket GDK_DISABLE_DEPRECATION_WARNINGS and avoid
deprecated API as much as possible.
Matthias Clasen [Fri, 2 May 2014 22:42:18 +0000 (18:42 -0400)]
GtkColorButton: Reduce internal use of deprecated API
Drop the blanket GDK_DISABLE_DEPRECATION_WARNINGS and avoid
deprecated API as much as possible.
Matthias Clasen [Fri, 2 May 2014 22:41:29 +0000 (18:41 -0400)]
GtkColorButton: Update deprecation warnings
It is not great to have deprecation warnings point to another
deprecated function. Update them to point to the eventual
replacement.
Matthias Clasen [Fri, 2 May 2014 22:23:58 +0000 (18:23 -0400)]
GtkDialog: Warn about lack of transient parents
We want make it mandatory for dialogs to have transient parents,
eventually. This is a first step in that direction.
Matthias Clasen [Fri, 2 May 2014 21:43:18 +0000 (17:43 -0400)]
teststack: don't enumerate transitions manually
Thats what introspection is for.
Matthias Clasen [Fri, 2 May 2014 21:15:49 +0000 (17:15 -0400)]
GtkStack: Avoid compiler warnings
gcc warns about unhandled enum values in these switch statements,
so add an empty default: case to placate the compiler.
Philip Chimento [Wed, 19 Mar 2014 03:42:59 +0000 (20:42 -0700)]
stack: Add counterparts of OVER_UP_DOWN transition
The GtkStackTransitionType enum now has OVER_DOWN_UP, OVER_LEFT_RIGHT,
and OVER_RIGHT_LEFT values to complement OVER_UP_DOWN.
https://bugzilla.gnome.org/show_bug.cgi?id=726676
Philip Chimento [Wed, 19 Mar 2014 00:49:46 +0000 (17:49 -0700)]
stack: More readability when adding transitions
This small refactor makes the code more readable when adding more
transition types that have left, right, up, and down variations.
It adds inline boolean functions to tell information about transition
types (avoiding long if clauses) and changes long chains of "else if
(transition_type == ...)" into switch statements. Both are only likely
to get longer as more transition types are added.
https://bugzilla.gnome.org/show_bug.cgi?id=726676
Cosimo Cecchi [Fri, 2 May 2014 18:32:15 +0000 (20:32 +0200)]
overlay: don't have a custom draw implementation
We can't think with Benjamin of a reason this should be needed, so let's
just remove it.
Cosimo Cecchi [Thu, 1 May 2014 23:39:35 +0000 (01:39 +0200)]
themingengine: only round outline corners after shrinking
Ensures the correctness of the applied radius.
Juan Pablo Ugarte [Fri, 2 May 2014 17:38:05 +0000 (14:38 -0300)]
GtkBuilder: added template parent type check.
Juan Pablo Ugarte [Thu, 1 May 2014 23:31:59 +0000 (20:31 -0300)]
GtkFlowBox: fixed NULL dereferencing segfaults
Juan Pablo Ugarte [Thu, 1 May 2014 23:31:31 +0000 (20:31 -0300)]
GtkMenu: fixed more NULL dereferencing segfault
Juan Pablo Ugarte [Thu, 1 May 2014 22:54:10 +0000 (19:54 -0300)]
GtkGrid: gtk_grid_get_size_for_size() do not dereference a NULL pointer.
Juan Pablo Ugarte [Tue, 29 Apr 2014 19:22:32 +0000 (16:22 -0300)]
GtkBuilder: improved parsing error report for invalid properties and signals.
Added GTK_BUILDER_ERROR_INVALID_PROPERTY and GTK_BUILDER_ERROR_INVALID_SIGNAL
error codes
ObjectInfo: Use a GType instead of a char * for the class name.
PropertyInfo: Use a GParamSpec instead of a char * for the property name.
SignalInfo: Use signal id and detail quark instead of a detailed signal name string.
This not only save us a few malloc in each case but lets us simplify the code
and report unknown properties and signals as a parsing error instead of just
printing a warning.
Juan Pablo Ugarte [Tue, 29 Apr 2014 16:48:16 +0000 (13:48 -0300)]
GtkBuilder: fixed a few minor memory leaks.
Fixed memory leaks in parse_object(), parse_template() and parse_signal() functions.
Parameters value where strduped before the last posible return and not freed.
Руслан Ижбулатов [Thu, 1 May 2014 18:17:30 +0000 (18:17 +0000)]
W32: override selected button style to remove colored background
https://bugzilla.gnome.org/show_bug.cgi?id=729353
Руслан Ижбулатов [Thu, 1 May 2014 17:09:40 +0000 (17:09 +0000)]
W32: Add a theme for .app-notification
This is copied from Adwaita. Looks sufficiently ok.
https://bugzilla.gnome.org/show_bug.cgi?id=729346
Cosimo Cecchi [Thu, 1 May 2014 17:46:47 +0000 (19:46 +0200)]
listbox: fix a segfault
Don't dereference a NULL pointer.
Cosimo Cecchi [Thu, 1 May 2014 17:43:20 +0000 (19:43 +0200)]
combobox: fix a segfault
Don't dereference a NULL pointer.
Cosimo Cecchi [Thu, 1 May 2014 16:12:35 +0000 (18:12 +0200)]
themingengine: use outlines to render focus rings
Instead of the old non-CSS implementation. This allows us to get rid of
the very last piece of custom theming in Adwaita.
Cosimo Cecchi [Thu, 1 May 2014 16:11:23 +0000 (18:11 +0200)]
css: add properties for outline-radius
Both a shorthand and individual properties. This is not officially part
of the CSS standard, but there's precedence for it at least in Mozilla:
https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-outline-radius
Cosimo Cecchi [Thu, 1 May 2014 16:07:25 +0000 (18:07 +0200)]
treeview: respect focus-padding when rendering focus
Adwaita had a hack to work this around, but now that we're moving focus
ring rendering into GTK, we can just fix the treeview instead.
Benjamin Otte [Thu, 1 May 2014 13:16:17 +0000 (15:16 +0200)]
treeview: Always call size request funcs with valid out pointers
Not doing so causes crashes since
a158a2aa48c8023f99963642cc2657bff207b82NULLd
Benjamin Otte [Wed, 30 Apr 2014 07:27:22 +0000 (09:27 +0200)]
revealer: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:26:28 +0000 (09:26 +0200)]
popover: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:24:17 +0000 (09:24 +0200)]
menuitem: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:23:04 +0000 (09:23 +0200)]
menu: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:22:29 +0000 (09:22 +0200)]
levelbar: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:21:54 +0000 (09:21 +0200)]
eventbox: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:19:33 +0000 (09:19 +0200)]
listbox: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:17:31 +0000 (09:17 +0200)]
frame: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:17:07 +0000 (09:17 +0200)]
headerbar: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:16:04 +0000 (09:16 +0200)]
infobar: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:15:24 +0000 (09:15 +0200)]
grid: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:12:40 +0000 (09:12 +0200)]
scrolledwindow: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:11:58 +0000 (09:11 +0200)]
switch: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:11:22 +0000 (09:11 +0200)]
toolbar: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:10:27 +0000 (09:10 +0200)]
treeview: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:09:39 +0000 (09:09 +0200)]
viewport: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 07:08:00 +0000 (09:08 +0200)]
viewport: Implement hfw properly
Previously, the code would fall back on GtkBin's hfw implementation
which didn't account for padding and borders.
Benjamin Otte [Wed, 30 Apr 2014 06:51:11 +0000 (08:51 +0200)]
viewport: Use a convenience function
That function looks longer than not using it, but we'll need it in the
next commit.
Benjamin Otte [Wed, 30 Apr 2014 06:47:00 +0000 (08:47 +0200)]
viewport: Request 2x border-width
It's nice that bugs get pointed out in code comments. Fixing them would
probably have been preferrable though.
Benjamin Otte [Wed, 30 Apr 2014 06:42:52 +0000 (08:42 +0200)]
widget: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 06:41:54 +0000 (08:41 +0200)]
flowbox: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 06:39:06 +0000 (08:39 +0200)]
combobox: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 06:38:39 +0000 (08:38 +0200)]
button: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 06:37:52 +0000 (08:37 +0200)]
alignment: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 06:36:48 +0000 (08:36 +0200)]
arrow: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Benjamin Otte [Wed, 30 Apr 2014 06:35:24 +0000 (08:35 +0200)]
spinner: Remove unneeded checks
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
Cosimo Cecchi [Thu, 1 May 2014 09:22:11 +0000 (11:22 +0200)]
modules: remove the pixbuf engine directory
This is not used anywhere, and is commented out of the build because it
doesn't compile. Time for some spring cleaning...
Piotr Drąg [Wed, 30 Apr 2014 20:14:24 +0000 (22:14 +0200)]
Updated POTFILES.skip
Matthias Clasen [Wed, 30 Apr 2014 01:46:38 +0000 (21:46 -0400)]
GtkSearchBar: fix the template
There was a mismatch between GtkSearchBar being derived from GtkBin
and the template claiming the parent to be GtkBox.
Matthias Clasen [Wed, 30 Apr 2014 01:43:11 +0000 (21:43 -0400)]
widget-factory: populate the second page more
Add back a menubar example that was lost a while ago, and also
include a searchbar and an infobar.
Matthias Clasen [Tue, 29 Apr 2014 20:51:44 +0000 (16:51 -0400)]
widget-factory: rearrange page 2 a bit
Benjamin Otte [Tue, 29 Apr 2014 17:34:44 +0000 (19:34 +0200)]
reftests: Add test for latest commit
Check that the label gets linebroken properly.
Benjamin Otte [Tue, 29 Apr 2014 17:26:06 +0000 (19:26 +0200)]
window: Subtract shadow from passed in width for height
... and height for width in size requests. Fixes mislayout in
control-center universal access panel.
Benjamin Otte [Wed, 16 Apr 2014 13:36:22 +0000 (15:36 +0200)]
widgets: Remove (GtkTickCallback) casts
Instead, make the functions conform to the prototype, so that casting
isn't needed.
Matthias Clasen [Tue, 29 Apr 2014 16:17:40 +0000 (12:17 -0400)]
GtkMenuSectionBox: Don't show separators for nested subsections
...unless they are labeled.
To implement this, keep track of the nesting depth of section boxes,
starting from 0 for the toplevel and the submenu ones, and only
insert unlabeled separators if the depth is at most 1.
Matthias Clasen [Tue, 29 Apr 2014 15:48:52 +0000 (11:48 -0400)]
GtkMenuSectionBox: Always show separators for labeled sections
...unless they are empty.
Matthias Clasen [Tue, 29 Apr 2014 15:50:54 +0000 (11:50 -0400)]
Add a comment with rules for separators
Juan Pablo Ugarte [Mon, 28 Apr 2014 21:10:39 +0000 (18:10 -0300)]
Added template test case to builder test.
Matthias Clasen [Tue, 29 Apr 2014 14:18:22 +0000 (10:18 -0400)]
GtkMenuSectionBox: don't leak
This wasn't fully fleshed out yet.
Matthias Clasen [Tue, 29 Apr 2014 10:21:11 +0000 (06:21 -0400)]
widget-factory: Add a horizontal-buttons example
Sadly, we don't have good icons for payment methods...
Alexander Larsson [Tue, 29 Apr 2014 07:08:31 +0000 (09:08 +0200)]
treeview: Fix prelight redraw when adjustment changes
When the adjustment changes (due to e.g. a mouse wheel scroll) we update
the prelight. The part that un-prelights the previous prelight was
broken by the the pixel cache, as it called update_prelight in the
middle of the scrolling operation, where the windows were moved
but the tree_view->priv->dy was not changed to the new value. This
caused the updates to the pixel cache to go to the wrong place.
We fix this by fully doing the scroll before we update_prelight().
https://bugzilla.gnome.org/show_bug.cgi?id=728284
Matthias Clasen [Tue, 29 Apr 2014 00:50:02 +0000 (20:50 -0400)]
3.13.1
Matthias Clasen [Tue, 29 Apr 2014 02:55:44 +0000 (22:55 -0400)]
Update output of a11y tests
These are all affected by the addition of the action_box in
GtkDialog or by the switch to popovers in GtkMenuButton.
Matthias Clasen [Tue, 29 Apr 2014 02:46:25 +0000 (22:46 -0400)]
GtkMenuShell: We want separators in submenus
This was probably an oversight when adding the merge_separators
parameter. Without this change, the testsuite/gtk/gtkmenu test
fails.
Matthias Clasen [Tue, 29 Apr 2014 01:53:35 +0000 (21:53 -0400)]
GtkMenuShell: Don't use a non-existing property
GtkMenuTrackerItem::visible was removed a few commits ago.
It is not necessary to bind visible anyway, since the menu
tracker will insert and remove items as their visibility
changes.
Matthias Clasen [Tue, 29 Apr 2014 01:53:03 +0000 (21:53 -0400)]
testmenubutton: Add a toggle for use-popover
Carlos Garnacho [Mon, 28 Apr 2014 19:19:40 +0000 (21:19 +0200)]
gdkwindow: ignore shape on client-side windows when recomputing visible regions
Rendering doesn't do much about clipping drawing operations to the window shape,
although invalidation applies the shape to every window, leaving possibly trails
of "overrendered" content. So ensure the shape portions get invalidated too when
the window is moved/resized.
https://bugzilla.gnome.org/show_bug.cgi?id=729095
Carlos Garnacho [Mon, 28 Apr 2014 18:34:49 +0000 (20:34 +0200)]
popover: Always make room for the tail on all sides on size request
Now that popovers may snap to any side with enough space, make enough
room on every side when requesting size, so that there's no w/h differences
at the time of setting the child allocation.
https://bugzilla.gnome.org/show_bug.cgi?id=729097
Juan Pablo Ugarte [Mon, 28 Apr 2014 17:46:48 +0000 (14:46 -0300)]
GtkRecentChooserMenu: Set current uri before activating an item.
When activating an item using mnemonics GtkRecentChooserMenu does not select a
item before calling the item-activated signal thus
gtk_recent_chooser_get_current_uri() always return the last selected item
instead of the activated one.
Fixes Bug 495105 "Open recent file keyboard shortcuts do not work correctly"
Matthias Clasen [Mon, 28 Apr 2014 19:38:17 +0000 (15:38 -0400)]
Raleigh: fix a typo
Matthias Clasen [Mon, 28 Apr 2014 19:36:34 +0000 (15:36 -0400)]
GtkDialog: protect against show_all
The real reason for the problem that the just reverted change
was supposed to address is that testfilechooser uses show_all
to tease out places where composite dialogs don't properly
protect their internals against unintended showing. Well,
lets do that, then.
Matthias Clasen [Mon, 28 Apr 2014 19:12:09 +0000 (15:12 -0400)]
Revert "GtkFileChooserDialog: Avoid a bottom border in the dialog"
This reverts commit
d871105fa8fd20f9be0d07953ee2dd7d90b4c84f.
Matej Urbančič [Mon, 28 Apr 2014 19:09:16 +0000 (21:09 +0200)]
Updated Slovenian translation
Matej Urbančič [Mon, 28 Apr 2014 19:07:38 +0000 (21:07 +0200)]
Updated Slovenian translation
Matthias Clasen [Sat, 26 Apr 2014 18:38:07 +0000 (14:38 -0400)]
Document iconic section support
https://bugzilla.gnome.org/show_bug.cgi?id=727477
Matthias Clasen [Wed, 2 Apr 2014 05:08:39 +0000 (01:08 -0400)]
Add an example of iconic rendering
testpopover now shows several examples of icon buttons.
https://bugzilla.gnome.org/show_bug.cgi?id=727477
Matthias Clasen [Mon, 28 Apr 2014 18:18:39 +0000 (14:18 -0400)]
GtkMenuSectionBox: add support for iconic sections
Sections that have the display-hint attribute set to
"horizontal-boxes" will be rendered as a row of icon
buttons, instead of menuitem-like.
Matthias Clasen [Mon, 28 Apr 2014 18:18:06 +0000 (14:18 -0400)]
GtkMenuTrackerItem: Add support for display-hint
This commit adds a getter for the display-hint attribute.
Matthias Clasen [Sat, 26 Apr 2014 17:50:55 +0000 (13:50 -0400)]
GtkModelButton: Add an iconic mode
In iconic mode, model buttons will be styled like regular icon
buttons, preferring to show only the icon if one is set, falling
back to showing the label.
https://bugzilla.gnome.org/show_bug.cgi?id=727477
Matthias Clasen [Sat, 26 Apr 2014 18:15:01 +0000 (14:15 -0400)]
GtkMenuTrackerItem: Add support for verb-icons
When rendering iconic sections, we want to use icons for verbs,
and we want to differentiate these in the menu model, to keep
the icon attribute reserved for nouns.
https://bugzilla.gnome.org/show_bug.cgi?id=727477
Ryan Lortie [Mon, 28 Apr 2014 15:55:52 +0000 (17:55 +0200)]
GtkPopover: new approach to menu model binding
Instead of using GtkMenuTracker to flatten the sections into a single
linear menu, handle the sections ourselves by nesting boxes.
Each section gets an inner and outer box. The inner box numbers its
children in the way that the tracker instructs. The outer box
containes the inner box and the separator, if appropriate.
Having the two separate boxes will allow us to change the orientation of
the inner box if we want to pack widgets horizontally within a section.
Ryan Lortie [Mon, 28 Apr 2014 12:20:08 +0000 (14:20 +0200)]
GtkMenuTracker: add 'merge_sections' flag
Add the possibility of a GtkMenuTracker that performs no section
merging. Instead, it will report an item in the form of a separator for
subsections. It is then possible to get a separate tracker for the
subsection contents by using gtk_menu_tracker_new_for_item_link().
Ryan Lortie [Mon, 28 Apr 2014 12:01:35 +0000 (14:01 +0200)]
GtkMenuTracker: don't specialise "submenu" link
We have some API in GtkMenuTracker and GtkMenuTrackerItem that is
specifically designed to deal with submenus.
Generalise these APIs to take a 'link_name' parameter that we always
give as G_MENU_SUBMENU for now. In the future, this will allow creating
trackers for other types of links, such as sections.
Ryan Lortie [Mon, 28 Apr 2014 08:12:51 +0000 (10:12 +0200)]
GtkMenuTracker: make "is-visible" a property
Make this a property just like all of the other things and make the APIs
for accessing it non-private (but add a note that they are not intended
to be used).
Ryan Lortie [Mon, 28 Apr 2014 08:12:25 +0000 (10:12 +0200)]
GtkMenuTracker: remove "visible" property
This is in conflict with the "is-visible" pseudo-property which is about
to be promoted to being an actual property.
Руслан Ижбулатов [Mon, 28 Apr 2014 15:51:51 +0000 (15:51 +0000)]
W32: Update the css to match the .modelbutton->.button.menuitem transition